Add structured logging to logs input #25299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logging of the logs input is updated to make use of structured logging. Each logs input instance will create an unique ID, that will be logged as "input_id". The input and harvester will also add file state information like: source, state_id, finished, os_id. The os_id holds the inode, and state_id is the ID that is used internally by filebeat to track the file. By filtering the logs for one or the other ID, one can track all logs at a different level. Filtering by "state_id" allows us to monitor all logs and state changes for a given file, even if the file is renamed, closed and reopened.
botelastic
bot
added
the
needs_team
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
kvch
reviewed
Apr 26, 2021
kvch
approved these changes
Apr 26, 2021
added 2 commits
April 26, 2021 23:22
kvch
approved these changes
Apr 27, 2021
|
Pinging @elastic/agent (Team:Agent) |
|
@urso is this something you want to add for 7.14? |
|
This pull request is now in conflicts. Could you fix it? 🙏 |
The item is 'complete' with this PR, so yeah it is 7.14 :) |
mergify bot
pushed a commit
that referenced
this pull request
Apr 28, 2021
(cherry picked from commit 448afd4)
urso
pushed a commit
that referenced
this pull request
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The logging of the logs input is updated to make use of structured
logging. Each logs input instance will create an unique ID, that will be
logged as "input_id".
The input and harvester will also add file state information like:
source, state_id, finished, os_id. The os_id holds the inode, and
state_id is the ID that is used internally by filebeat to track the
file.
Why is it important?
By filtering the logs for one or the other ID, one can track all
logs at a different level. Filtering by "state_id" allows us to monitor
all logs and state changes for a given file, even if the file is
renamed, closed and reopened.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Run filebeat with the logs input and debug logs enabled.
File state updates after a scan or harvester logs should log contextual information like the inode, state_id, harvester_id, input_id.